fix(dashboard,api): minor improvement for integrations and notifications

This commit is contained in:
Carl-Gerhard Lindesvärd
2024-10-03 20:48:37 +02:00
parent 4329960bd9
commit f450a2871b
8 changed files with 47 additions and 30 deletions

View File

@@ -70,6 +70,7 @@ export function DiscordIntegrationForm({
>
<InputWithLabel
label="Name"
placeholder="Eg. My personal discord"
{...form.register('name')}
error={form.formState.errors.name?.message}
/>

View File

@@ -54,6 +54,7 @@ export function SlackIntegrationForm({
>
<InputWithLabel
label="Name"
placeholder="Eg. My personal slack"
{...form.register('name')}
error={form.formState.errors.name?.message}
/>

View File

@@ -59,6 +59,7 @@ export function WebhookIntegrationForm({
>
<InputWithLabel
label="Name"
placeholder="Eg. Zapier webhook"
{...form.register('name')}
error={form.formState.errors.name?.message}
/>

View File

@@ -1,4 +1,4 @@
import type { IIntegrationConfig } from '@openpanel/db';
import type { IIntegrationConfig } from '@openpanel/validation';
import { WebhookIcon } from 'lucide-react';
import {
IntegrationCardLogo,

View File

@@ -4,8 +4,9 @@ import { useAppParams } from '@/hooks/useAppParams';
import { pushModal } from '@/modals';
import { api } from '@/trpc/client';
import { AnimatePresence, motion } from 'framer-motion';
import { BoxSelectIcon, PlusIcon } from 'lucide-react';
import { BoxSelectIcon, PencilRulerIcon, PlusIcon } from 'lucide-react';
import { useMemo } from 'react';
import { FullPageEmptyState } from '../full-page-empty-state';
import {
IntegrationCard,
IntegrationCardLogo,
@@ -25,6 +26,28 @@ export function NotificationRules() {
const isLoading = query.isLoading;
if (!isLoading && data.length === 0) {
return (
<FullPageEmptyState title="No rules yet" icon={PencilRulerIcon}>
<p>
You have not created any rules yet. Create a rule to start getting
notifications.
</p>
<Button
className="mt-8"
variant="outline"
onClick={() =>
pushModal('AddNotificationRule', {
rule: undefined,
})
}
>
Add Rule
</Button>
</FullPageEmptyState>
);
}
return (
<div>
<div className="mb-2">
@@ -48,17 +71,6 @@ export function NotificationRules() {
<IntegrationCardSkeleton />
</>
)}
{!isLoading && data.length === 0 && (
<IntegrationCard
icon={
<IntegrationCardLogo className="bg-def-200 text-foreground">
<BoxSelectIcon className="size-10" strokeWidth={1} />
</IntegrationCardLogo>
}
name="No integrations yet"
description="Integrations allow you to connect your systems to OpenPanel. You can add them in the available integrations section."
/>
)}
<AnimatePresence mode="popLayout">
{data.map((item) => {
return (

View File

@@ -7,16 +7,15 @@ import type { UseQueryResult } from '@tanstack/react-query';
import { GanttChartIcon } from 'lucide-react';
import type { Dispatch, SetStateAction } from 'react';
import type { Notification } from '@openpanel/db';
import type { RouterOutputs } from '@/trpc/client';
import { useColumns } from './columns';
type Props =
| {
query: UseQueryResult<Notification[]>;
query: UseQueryResult<RouterOutputs['notification']['list'][number][]>;
}
| {
query: UseQueryResult<Notification[]>;
query: UseQueryResult<RouterOutputs['notification']['list'][number][]>;
cursor: number;
setCursor: Dispatch<SetStateAction<number>>;
};
@@ -31,8 +30,8 @@ export const NotificationsTable = ({ query, ...props }: Props) => {
if (data?.length === 0) {
return (
<FullPageEmptyState title="No events here" icon={GanttChartIcon}>
<p>Could not find any events</p>
<FullPageEmptyState title="No notifications here" icon={GanttChartIcon}>
<p>Could not find any notifications</p>
{'cursor' in props && props.cursor !== 0 && (
<Button
className="mt-8"