fix: timezone issue + improvements for funnel and conversion charts

This commit is contained in:
Carl-Gerhard Lindesvärd
2025-10-30 11:04:41 +01:00
parent ddc99e9850
commit 931188a8ab
15 changed files with 128 additions and 103 deletions

View File

@@ -191,14 +191,16 @@ const { Tooltip, TooltipProvider } = createChartTooltip<
<span>{item.total}</span>
</div>
<div className="col gap-1">
<PreviousDiffIndicatorPure
{...getPreviousMetric(item.rate, prevItem?.rate)}
/>
<span className="text-muted-foreground">
({prevItem?.total})
</span>
</div>
{!!prevItem && (
<div className="col gap-1">
<PreviousDiffIndicatorPure
{...getPreviousMetric(item.rate, prevItem?.rate)}
/>
<span className="text-muted-foreground">
({prevItem?.total})
</span>
</div>
)}
</div>
</div>
</div>

View File

@@ -6,15 +6,17 @@ import { ChevronRightIcon, InfoIcon } from 'lucide-react';
import { alphabetIds } from '@openpanel/constants';
import { createChartTooltip } from '@/components/charts/chart-tooltip';
import { BarShapeBlue } from '@/components/charts/common-bar';
import { Tooltiper } from '@/components/ui/tooltip';
import { WidgetTable } from '@/components/widget-table';
import { useNumber } from '@/hooks/use-numer-formatter';
import { getChartColor } from '@/utils/theme';
import { getPreviousMetric } from '@openpanel/common';
import {
Bar,
BarChart,
CartesianGrid,
Line,
LineChart,
Cell,
ResponsiveContainer,
XAxis,
YAxis,
@@ -205,8 +207,10 @@ export function Tables({
{
name: 'Event',
render: (item, index) => (
<div className="row items-center gap-2 row min-w-0 relative">
<ColorSquare>{alphabetIds[index]}</ColorSquare>
<div className="row items-center gap-2 min-w-0 relative">
<ColorSquare color={getChartColor(index)}>
{alphabetIds[index]}
</ColorSquare>
<span className="truncate">{item.event.displayName}</span>
</div>
),
@@ -265,6 +269,7 @@ const useRechartData = ({
return (
firstFunnel?.steps.map((step, stepIndex) => {
return {
id: step?.event.id ?? '',
name: step?.event.displayName ?? '',
...current.reduce((acc, item, index) => {
const diff = previous?.[index];
@@ -299,7 +304,7 @@ export function Chart({ data }: { data: RouterOutputs['chart']['funnel'] }) {
<TooltipProvider data={data.current}>
<div className="aspect-video max-h-[250px] w-full p-4 card pb-1">
<ResponsiveContainer>
<LineChart data={rechartData}>
<BarChart data={rechartData}>
<CartesianGrid
strokeDasharray="3 3"
horizontal={true}
@@ -308,7 +313,7 @@ export function Chart({ data }: { data: RouterOutputs['chart']['funnel'] }) {
/>
<XAxis
{...xAxisProps}
dataKey="name"
dataKey="id"
allowDuplicatedCategory={false}
type={'category'}
scale="auto"
@@ -316,19 +321,19 @@ export function Chart({ data }: { data: RouterOutputs['chart']['funnel'] }) {
interval="preserveStartEnd"
tickSize={0}
tickMargin={4}
tickFormatter={(id) =>
data.current[0].steps.find((step) => step.event.id === id)
?.event.displayName ?? ''
}
/>
<YAxis {...yAxisProps} />
{data.current.map((item, index) => (
<Line
stroke={getChartColor(index)}
key={`step:percent:${item.id}`}
dataKey={`step:percent:${index}`}
type="linear"
strokeWidth={2}
/>
))}
<Bar data={rechartData} dataKey="step:percent:0">
{rechartData.map((item, index) => (
<Cell key={item.name} fill={getChartColor(index)} />
))}
</Bar>
<Tooltip />
</LineChart>
</BarChart>
</ResponsiveContainer>
</div>
</TooltipProvider>

View File

@@ -44,7 +44,7 @@ export function ReportFunnelChart() {
const trpc = useTRPC();
const res = useQuery(
trpc.chart.funnel.queryOptions(input, {
enabled: !isLazyLoading,
enabled: !isLazyLoading && input.events.length > 0,
}),
);