From 86bf9dd06412c879c537f7c4d06064ee74c90d4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carl-Gerhard=20Lindesva=CC=88rd?= Date: Mon, 24 Feb 2025 23:24:25 +0100 Subject: [PATCH] remove(api): profile alias are no gone since not used --- apps/api/src/controllers/track.controller.ts | 37 +++----------- packages/db/src/services/profile.service.ts | 52 -------------------- 2 files changed, 6 insertions(+), 83 deletions(-) diff --git a/apps/api/src/controllers/track.controller.ts b/apps/api/src/controllers/track.controller.ts index 61345c98..02f15485 100644 --- a/apps/api/src/controllers/track.controller.ts +++ b/apps/api/src/controllers/track.controller.ts @@ -4,17 +4,10 @@ import type { FastifyReply, FastifyRequest } from 'fastify'; import { path, assocPath, pathOr, pick } from 'ramda'; import { generateDeviceId, parseUserAgent } from '@openpanel/common/server'; -import { - createProfileAlias, - getProfileById, - getProfileIdCached, - getSalts, - upsertProfile, -} from '@openpanel/db'; +import { getProfileById, getSalts, upsertProfile } from '@openpanel/db'; import { eventsQueue } from '@openpanel/queue'; import { getRedisCache } from '@openpanel/redis'; import type { - AliasPayload, DecrementPayload, IdentifyPayload, IncrementPayload, @@ -110,12 +103,7 @@ export async function handler( } const identity = getIdentity(request.body); - const profileId = identity?.profileId - ? await getProfileIdCached({ - projectId, - profileId: identity?.profileId, - }) - : undefined; + const profileId = identity?.profileId; // We might get a profileId from the alias table // If we do, we should use that instead of the one from the payload @@ -183,9 +171,10 @@ export async function handler( break; } case 'alias': { - await alias({ - payload: request.body.payload, - projectId, + reply.status(400).send({ + status: 400, + error: 'Bad Request', + message: 'Alias is not supported', }); break; } @@ -305,20 +294,6 @@ async function identify({ }); } -async function alias({ - payload, - projectId, -}: { - payload: AliasPayload; - projectId: string; -}) { - await createProfileAlias({ - alias: payload.alias, - profileId: payload.profileId, - projectId, - }); -} - async function increment({ payload, projectId, diff --git a/packages/db/src/services/profile.service.ts b/packages/db/src/services/profile.service.ts index 8bc73f87..f3647df6 100644 --- a/packages/db/src/services/profile.service.ts +++ b/packages/db/src/services/profile.service.ts @@ -188,30 +188,6 @@ export function transformProfile({ }; } -export async function createProfileAlias({ - projectId, - alias, - profileId, -}: { - projectId: string; - alias: string; - profileId: string; -}) { - await getProfileIdCached.clear({ profileId, projectId }); - await ch.insert({ - table: TABLE_NAMES.alias, - format: 'JSONEachRow', - values: [ - { - projectId, - profile_id: profileId, - alias, - created_at: new Date(), - }, - ], - }); -} - export async function upsertProfile( { id, @@ -240,31 +216,3 @@ export async function upsertProfile( isFromEvent, ); } - -export async function getProfileId({ - profileId, - projectId, -}: { - profileId: number | string | undefined; - projectId: string; -}) { - if (!profileId) { - return ''; - } - - const res = await chQuery<{ - alias: string; - profile_id: string; - project_id: string; - }>( - `SELECT * FROM ${TABLE_NAMES.alias} WHERE project_id = '${projectId}' AND (alias = '${profileId}' OR profile_id = '${profileId}')`, - ); - - if (res[0]) { - return res[0].profile_id; - } - - return String(profileId); -} - -export const getProfileIdCached = cacheable(getProfileId, 60 * 30);